This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix: check if 'location' exists on Document object #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NativeScript has a fake global 'document' object, which doesn't have a 'location' property. This PR introduces a check that the 'location' property is defined before retrieving it and allows the package to be used with NativeScript.
|
Fixed in Angular 6.1-beta.3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeScript has a fake global 'document' object, which doesn't
have a 'location' property. This PR introduces a check that the
'location' property is defined before retrieving it and allows the
package to be used with NativeScript.
related to angular/angular#22093